Conversation
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
|
It is actually quite easy to support all of them: |
|
Given that PHPUnit seemingly always deprecates/removes something for every major version, and that this is a dev dependency, I have little interest in trying to support multiple versions of phpunit concurrently. |
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
| * @coversNothing | ||
| */ | ||
| abstract class AbstractConfigTest extends TestCase | ||
| abstract class AbstractConfigTestCase extends TestCase |
There was a problem hiding this comment.
Renamed this as it wasn't a file that had tests, but rather something the concrete Config*Test files extended to make use of the same helper functions. phpunit 10 starting having a warning about this, so renaming to AbstractConfigTestCase seemed most in keeping with the naming scheme that phpunit uses, and avoids the warning.
|
|
||
| if [[ ${{ matrix.prefer-lowest != 'prefer-lowest' }} ]]; then | ||
| export CODECOVERAGE=1 && vendor/bin/phpunit --verbose --coverage-clover=coverage.xml | ||
| export CODECOVERAGE=1 && vendor/bin/phpunit --coverage-clover=coverage.xml |
There was a problem hiding this comment.
I think the biggest change would be no longer printing out the skipped tests, but I think that's actually preferable as they were essentially just noise for the most part and something to annoyingly scroll past to see actual test errors.
If we wanted to bring back the behavior, can use the new --display-skipped flag or displayDetailsOnSkippedTests XML option.
2 participants
PR updates the phpunit dev dependency to
^10.5which is the latest major version that supports 8.1, which phinx supports. At the moment, I don't think there's value in also doing something like was in #2371 where we try to support multiple phpunit versions, unless there's something that comes up that's only possible in phpunit 11+ (which to my knowledge we've not hit).